Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

40 owner of #49

Merged
merged 7 commits into from
Apr 12, 2022
Merged

40 owner of #49

merged 7 commits into from
Apr 12, 2022

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Apr 6, 2022

@vikiival vikiival self-assigned this Apr 6, 2022
This was linked to issues Apr 6, 2022
Extend events with the current NFT owner #40
Closed
Create UNLIST interaction #48
Closed
@vikiival vikiival mentioned this pull request Apr 6, 2022
Closed
@yangwao
Copy link
Member

yangwao commented Apr 8, 2022

Time to merge it?

@Jarsen136 Jarsen136 mentioned this pull request Apr 12, 2022
Closed
@vikiival
Copy link
Member Author

@roiLeo @kkukelka can I ask you to make a code review ? :)

roiLeo
roiLeo reviewed Apr 12, 2022
View reviewed changes
src/mappings/index.ts Outdated Show resolved Hide resolved
roiLeo
roiLeo reviewed Apr 12, 2022
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in src/mappings/index.ts would it not miss the RmrkEvent.UNLISTevent in switch case of mainFrame?

@vikiival @roiLeo
Update src/mappings/index.ts
e38afd6 
Co-authored-by: roiLeo <medina.leo42@gmail.com>
@vikiival
Copy link
Member Author

Thanks Leo!
I expected some glitches >.<

@vikiival
Copy link
Member Author

would it not miss the RmrkEvent.UNLIST

There is no such event as UNLIST .

UNLIST is LIST for 0 KSM

vikiival
vikiival commented Apr 12, 2022
View reviewed changes
src/mappings/utils/types.ts Outdated Show resolved Hide resolved
@vikiival vikiival merged commit 884336f into main Apr 12, 2022
@vikiival vikiival deleted the 40-owner-of branch April 12, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo left review comments

@kkukelka kkukelka Awaiting requested review from kkukelka

Assignees

@vikiival vikiival

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create UNLIST interaction Extend events with the current NFT owner
3 participants
@vikiival @yangwao @roiLeo